Code Review Is a Teaching Opportunity, Not Gatekeeping

·1 min read·

The culture around code review determines whether it produces better engineers or resentful ones.

Code review has two failure modes: no review (problems ship) and punishing review (reviewers demonstrate superiority rather than improve code).

The purpose: catch bugs, maintain quality standards, share knowledge, and develop the reviewed engineer's skills. All four. Not just the first two.

The practices: ask questions instead of making demands. Acknowledge what is done well before raising concerns. Distinguish "must fix" issues from "consider changing" issues. Explain the reasoning behind every requested change.

How you review code says as much about you as an engineer as the code you write.

— Dick Bassey | DevDick | 2024

Share this article
← Back to all writing